Clean up and add doc for dynamo_mark_sharding #7281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Jun 14, 2024
docs/spmd.md
Outdated
| import torch_xla.experimental.dynamo_mark_sharding | ||
| device_ids = [i for i in range(self.num_devices)] # List[int] | ||
| mesh_shape = [self.num_devices//2, 1, 2] # List[int] | ||
| axis_names = 'None' # string version of axis_names |
There was a problem hiding this comment.
can we use axis_names instead of numbers for partition_spec ? I want to update this doc to encourage user to give each mesh axis a name. I think this is more clear.
There was a problem hiding this comment.
Makes sense! Just updated.
JackCaoG
reviewed
Jun 14, 2024
docs/spmd.md
Outdated
| device_ids = [i for i in range(self.num_devices)] # List[int] | ||
| mesh_shape = [self.num_devices//2, 1, 2] # List[int] | ||
| axis_names = '(data, model)' # string version of axis_names | ||
| partition_spec = '(model, data)' # string version of partition spec |
There was a problem hiding this comment.
is this right? I believe you need "('data', 'model')"
There was a problem hiding this comment.
You're absolutely right. Updated.
JackCaoG
reviewed
Jun 14, 2024
docs/spmd.md
Outdated
| import torch_xla.experimental.dynamo_mark_sharding | ||
| device_ids = [i for i in range(self.num_devices)] # List[int] | ||
| mesh_shape = [self.num_devices//2, 1, 2] # List[int] | ||
| axis_names = '(data, model)' # string version of axis_names |
There was a problem hiding this comment.
same, I think you need "('data', 'model')"
|
Skipping the CI as it is just a docs change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_dynamo_custom_opsince it's not used anymore)