Egaerly execute inplace ops if in eager mode #7322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with functionization we still see some inplace ops, like
optimization_barrier_
,all_reduce_
, currently in eager mode they won't be execute.The eager mode today works by
xla/torch_xla/csrc/tensor.cpp
Lines 81 to 93 in 98dd99e
when creating a new XLATensor with a IR, we will execute that IR. This doesn't handle the inplace update cases since there is no new XLATensor being created.
I also need to handle the two special cases in follow up pr