Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openxla pin to 11 July 2024 #7639

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Update openxla pin to 11 July 2024 #7639

merged 6 commits into from
Jul 12, 2024

Conversation

bhavya01
Copy link
Collaborator

@bhavya01 bhavya01 commented Jul 8, 2024

openxla/xla#13930 Updated XLA IFRT API to return AttributeMap for device attributes. Updated our code appropriately.

Tested locally:

torchnightly) bbahl@t1v-n-2960fe6c-w-0:~/pytorch/xla$ XLA_USE_IFRT=1 python
Python 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import torch_xla
>>> torch_xla._XLAC._xla_get_device_attributes('xla:0')
{'num_cores': 2, 'core_on_chip': 0, 'coords': [0, 0, 0]}
>>> torch_xla._XLAC._xla_get_device_attributes('xla:1')
{'num_cores': 2, 'core_on_chip': 0, 'coords': [1, 0, 0]}
>>> 

@bhavya01 bhavya01 added the tpuci label Jul 8, 2024
@bhavya01 bhavya01 self-assigned this Jul 8, 2024
@JackCaoG JackCaoG requested a review from will-cromar July 8, 2024 20:47
Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JackCaoG
Copy link
Collaborator

seems like test still failed, wondering if the patch actually works

@will-cromar
Copy link
Collaborator

Be sure to add the new patch to patches in WORKSPACE, otherwise it has no effect

@bhavya01 bhavya01 changed the title Update openxla pin to 8 July 2024 Update openxla pin to 11 July 2024 Jul 11, 2024
@bhavya01 bhavya01 merged commit 8043050 into master Jul 12, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants