Fix norm
data-type when using AMP.
#7878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the result of
norm
operation when using AMP.The cast policy defined in autocast_mode.cpp for
norm.ScalarOpt_dim
is:fp32_append_dtype
. Which means that it will forward the call tonorm.ScalarOpt_dim_dtype
, appendingat::kFloat
(i.e.float32
) as its last argument. Such an argument represents the data-type of the result tensor.Even though we were correctly lowering the operation so as to return a
float32
tensor, upon checking, the result tensor actually inherited its data-type from the input. The solution was to callXLATensor::CreateFrom
withat::kFloat
argument. The example below illustrates the problem:cc @miladm @JackCaoG