Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Fix processing of PyTorch profiler events. #7930

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ysiraichi
Copy link
Collaborator

This PR fixes the benchmarking scripts when processing the recorded events from the PyTorch profiler. This modifies the scripts so that running with --profile-cuda-and-cpu and/or --profile-cuda-and-cpu-individual-ops works after pytorch/pytorch#123247.

cc @miladm @zpcore

@ysiraichi ysiraichi requested a review from zpcore August 29, 2024 22:10
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qihqi qihqi merged commit 1b4b828 into master Aug 30, 2024
23 checks passed
@qihqi qihqi deleted the ysiraichi/fix-pytorch-profiler-processing branch August 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants