Remove contiguity assertion from XLATensorImpl.
#7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any chance you can add a test? |
|
Problem is, I don't think anything will change (e.g. strides and storage offset) before merging pytorch/pytorch#135498. So, not sure what kind of test would make sense, here. |
JackCaoG
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reflects the changes in the PyTorch PR pytorch/pytorch#135237. Basically, it removes the contiguity assertion due to a possible metadata change in the functionalization kernel.
Specifically, at the end of each functionalization kernel,
at::functionalization::impl::set_sizes_strides_offsetis called. It modifies the metadata of the output tensors, so that they match the metadata of eager. Such a metadata update might setTensorImpl::is_contiguous_to false.cc @miladm @JackCaoG @alanwaketan