Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmarks] Disallow XRT for XLA:CUDA. #8006

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[benchmarks] Disallow XRT for XLA:CUDA. #8006

merged 1 commit into from
Sep 13, 2024

Conversation

ysiraichi
Copy link
Collaborator

This PR filters out "XRT" as an option for xla configuration on non-TPU experiments.

cc @miladm @zpcore

zpcore
zpcore approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, actually we doesn't support xrt anymore. xrt has already been cleared in runtime.py etc..

@ysiraichi ysiraichi merged commit afbd7bd into master Sep 13, 2024
23 checks passed
@ysiraichi ysiraichi mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpcore zpcore zpcore approved these changes

Assignees
No one assigned
Labels
xla:gpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ysiraichi @zpcore