Update and short circuit the Neuron initialization #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpsilva-aws
force-pushed
the
rpsilva-aws_short_circuit_neuron_initializer
branch
from
33f48dc to
c5abe1d
Compare
will-cromar
approved these changes
Sep 19, 2024
jeffhataws
approved these changes
Sep 19, 2024
rpsilva-aws
deleted the
rpsilva-aws_short_circuit_neuron_initializer
branch
jeffhataws
pushed a commit
that referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we re-initialize the environment for Neuron when
torch-neuronxis present. In this change, we decouple the initialization whentorch-neuronxis present. In the meantime, we also short circuit the returning value iflibneuronxlais not present.