[benchmarks] Default to functionalization disabled. #8093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defaults benchmarks execution to PyTorch/XLA without the functionalization layer. In summary:
--enable-functionalization
command-line argumentXLA_DISABLE_FUNCTIONALIZATION=1
Reasoning: after running experiments, it became clear that disabling functionalization reduced overhead, improving performance of, mainly, non-dynamo configurations. The speedup we get from this is:
Note: since functionalization is required for correctly supporting aliasing and in-place mutation on views. Turning this option off means that there will be more model failures. Specifically:
Inference + NonDynamo:
Inference + Dynamo:
Training + NonDynamo:
Training + Dynamo:
cc @miladm @JackCaoG @zpcore