Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TR events are not handled #131

Closed
RealCLanger opened this issue Oct 19, 2024 · 1 comment
Closed

Some TR events are not handled #131

RealCLanger opened this issue Oct 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@RealCLanger
Copy link
Contributor

Description of the bug
In my TR history there are a few events that don't seem to be picked up correctly by pytr yet and hence are missing in account_transactions.csv after dl_docs.

These are namely:
OUTGOING_TRANSFER (Probably an old name for outgoing bank transfer events)
benefits_spare_change_execution (Transactions for the Spare Change plan)
ssp_tax_correction_invoice: Tax corrections, e.g. after different trades with negative saldo occur on the same day.

To Reproduce
Steps to reproduce the behavior:

  1. Run the command pytr dl_docs for an account that has either of the events mentioned above
  2. According entries will be missing in account_transactions.csv

Expected behavior
Matching csv entries should be written.

Environment

  • OS: Windows
  • pytr version: 0.2.5
@RealCLanger RealCLanger added the bug Something isn't working label Oct 19, 2024
RealCLanger added a commit to RealCLanger/pytr that referenced this issue Oct 19, 2024
@RealCLanger RealCLanger changed the title Some TR events are not handled correctly. Some TR events are not handled Oct 19, 2024
Katzmann1983 pushed a commit that referenced this issue Oct 21, 2024
* pytr #131: Handle additional events
@Katzmann1983
Copy link
Collaborator

Merged. Thanks for the commit and keeping the code simple and clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants