-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fill value for integer datasets, fix band assignment #298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 92.60% 92.65% +0.04%
==========================================
Files 43 43
Lines 9077 9104 +27
==========================================
+ Hits 8406 8435 +29
+ Misses 671 669 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the concise code and refactorings. Just the tests are missing.
I believe everything is now tested. |
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Since some recent changes in Satpy resampling a of mix of float and integer datasets (e.g. when using
BackgroundCompositor
) in to one output was broken in two ways inXArrayResamplerBilinear
.fill_value
was set tonp.nan
even for the integer datasetRGBA
and anotherRGB
bands, sometimes there were problems assigning the correct bands to the output dataset after resampling.I'm not entirely sure why this happens, but this fixes it.
git diff origin/master **/*py | flake8 --diff