Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test compatibility with new pyproj #304

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Oct 22, 2020

Recent pyproj introduced a different naming for the web-mercator projection.
The patch takes into account of the different naming and make all tests pass properly also with new versions of pyproj.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

Edit: see also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949274

@avalentino
Copy link
Contributor Author

Rebased on the current master

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #304 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          45       45           
  Lines        9134     9135    +1     
=======================================
+ Hits         8463     8464    +1     
  Misses        671      671           
Impacted Files Coverage Δ
pyresample/test/test_utils.py 98.42% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd8054...524048a. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 28, 2020

Coverage Status

Coverage increased (+0.0008%) to 92.655% when pulling 524048a on avalentino:pyproj-compat into bbd8054 on pytroll:master.

@djhoese
Copy link
Member

djhoese commented Oct 28, 2020

Thanks!

@djhoese djhoese merged commit 77fc933 into pytroll:master Oct 28, 2020
@djhoese djhoese changed the title Improve compatibility with new pyproj Improve test compatibility with new pyproj Oct 28, 2020
@djhoese djhoese added the bug label Oct 28, 2020
@djhoese djhoese self-assigned this Oct 28, 2020
@avalentino avalentino deleted the pyproj-compat branch October 28, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants