Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated numpy data type usage in bilinear resampling #399

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

danschef
Copy link
Contributor

This fixes a DeprecationWarning coming from numpy:

/root/mambaforge/envs/ci_env/lib/python3.10/site-packages/pyresample/bilinear/_base.py:220
`np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here. Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

Signed-off-by: Daniel Scheffler <danschef@gfz-potsdam.de>
@djhoese djhoese requested a review from pnuu November 26, 2021 04:00
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #399 (33d09be) into main (e6a452e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          65       65           
  Lines       11076    11076           
=======================================
  Hits        10391    10391           
  Misses        685      685           
Flag Coverage Δ
unittests 93.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/bilinear/_base.py 95.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a452e...33d09be. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.619% when pulling 33d09be on danschef:main into e6a452e on pytroll:main.

@djhoese djhoese added the bug label Dec 8, 2021
@djhoese djhoese changed the title Fixed deprecated numpy data type. Fix deprecated numpy data type usage in bilinear resampling Dec 8, 2021
@djhoese
Copy link
Member

djhoese commented Dec 8, 2021

Looks good to me. Thank you.

@djhoese djhoese merged commit eccb2aa into pytroll:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants