Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask EWA code not creating unique dask task names for different target areas #404

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 7, 2021

I've always tested the new algorithm with only one target, but once it was thrown into Polar2Grid we quickly realized that multiple targets was a problem. Luckily because of my map_blocks PR last week I knew to look at the dask task names for the issue.

  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff

@djhoese djhoese added the bug label Dec 7, 2021
@djhoese djhoese requested a review from mraspaud December 7, 2021 17:00
@djhoese djhoese self-assigned this Dec 7, 2021
@djhoese
Copy link
Member Author

djhoese commented Dec 7, 2021

Oh I should note I also added a small fix to the deploy CI so it doesn't run on all types of "published" events. It was something I noticed during the last release that I forgot to push then.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #404 (0a9662e) into main (0b35d70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   93.83%   93.84%           
=======================================
  Files          65       65           
  Lines       11118    11129   +11     
=======================================
+ Hits        10433    10444   +11     
  Misses        685      685           
Flag Coverage Δ
unittests 93.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/ewa/dask_ewa.py 90.98% <100.00%> (ø)
pyresample/test/test_dask_ewa.py 98.92% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b35d70...0a9662e. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 3f95425 into pytroll:main Dec 7, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 93.65% when pulling 0a9662e on djhoese:bugfix-dask-ewa-unique-name into 0b35d70 on pytroll:main.

@djhoese djhoese deleted the bugfix-dask-ewa-unique-name branch December 7, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants