Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_abs_max on BucketResampler #418

Merged
merged 13 commits into from
May 6, 2022

Commits on Feb 4, 2022

  1. Add test for get_abs_max

    Add a (failing) unit test for the new (not yet implemented) get_abs_max
    and get_abs_min methods on the BucketResampler class.
    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    ee6acc1 View commit details
    Browse the repository at this point in the history
  2. First attempt to implement get_abs_max

    First attempt to implement get_abs_max for the bucket resampler.  It's
    failing because ``da.where`` return ``NotImplemented``.  I don't
    understand the problem.
    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    3b0a7da View commit details
    Browse the repository at this point in the history
  3. PEP8 errors

    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    862f91b View commit details
    Browse the repository at this point in the history
  4. Fix implementation for get_abs_max

    Fix the implementation for get_abs_max.
    
    Remove implementation and test for get_abs_min because it's harder to
    implement and I don't need it.
    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    429e01e View commit details
    Browse the repository at this point in the history
  5. Remove unreachable code

    Remove some code that is unreachable and untested
    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    a742fd8 View commit details
    Browse the repository at this point in the history
  6. Return accidentally removed unit test.

    Recover the unit test accidentally deleted in a previous commit.
    gerritholl committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    c1239da View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. increase max_computer to make test pass

    If I increase max_computes in the unit test, the test passes
    gerritholl committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2ae033c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Clarify get_abs_max docs.

    gerritholl committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    9d9ece8 View commit details
    Browse the repository at this point in the history
  2. don't shadow builtins

    rename min/max local variables as to not shadow builtins
    gerritholl committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    325c00c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Ensure no computations

    Change max-computes from 3 to 0 in get_abs_max test
    gerritholl committed May 2, 2022
    Configuration menu
    Copy the full SHA
    933f4b9 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Add doc for missing argument in get_abs_max

    In the bucket resampler get_abs_max method, add the missing fill_value
    to the method documentation.
    gerritholl committed May 4, 2022
    Configuration menu
    Copy the full SHA
    cc377d6 View commit details
    Browse the repository at this point in the history
  2. Refactor get_abs_max

    Refactor the BucketResampler.get_abs_max method.  Move the calculation
    of the abs_max from min and max to its own (pseudoprivate) method.
    gerritholl committed May 4, 2022
    Configuration menu
    Copy the full SHA
    70b24c1 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Configuration menu
    Copy the full SHA
    8520670 View commit details
    Browse the repository at this point in the history