Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython classifier to package metadata #427

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 4, 2022

A request was recently posted on the python mailing list about including Cython as the language of your package in the setup.py metadata. This PR adds that classifier.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #427 (b82a750) into main (d6cc9e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          65       65           
  Lines       11252    11252           
=======================================
  Hits        10572    10572           
  Misses        680      680           
Flag Coverage Δ
unittests 93.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cc9e4...b82a750. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.78% when pulling b82a750 on djhoese:add-cython-classifier into d6cc9e4 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 1b14698 into pytroll:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants