Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary method to AreaDefinition and SwathDefinition #473

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

ghiggi
Copy link
Contributor

@ghiggi ghiggi commented Nov 14, 2022

This PR adds the method boundary to AreaDefinition and SwathDefinition.
It enables the correct retrieval of an AreaBoundary object, which in future will be used to interface with the new spherical interface.

  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #473 (2038dae) into main (ff0e843) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   94.24%   94.31%   +0.06%     
==========================================
  Files          73       74       +1     
  Lines       12703    12855     +152     
==========================================
+ Hits        11972    12124     +152     
  Misses        731      731              
Flag Coverage Δ
unittests 94.31% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/boundary.py 95.58% <100.00%> (+1.14%) ⬆️
pyresample/geometry.py 87.40% <100.00%> (+0.23%) ⬆️
pyresample/test/test_boundary.py 100.00% <100.00%> (ø)
pyresample/test/test_geometry.py 99.53% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Nov 14, 2022

Coverage Status

Coverage remained the same at 93.834% when pulling 2038dae on ghiggi:feature-area-boundary-method into ff0e843 on pytroll:main.

@ghiggi
Copy link
Contributor Author

ghiggi commented Nov 17, 2022

@djhoese is there something that I still need to address prior merging it?

@djhoese
Copy link
Member

djhoese commented Nov 17, 2022

Waiting for merge of #475, then remerge of main into this branch, then tests to get updated and pass.

@djhoese
Copy link
Member

djhoese commented Nov 17, 2022

Ok #475 is merged, can you merge main here and then update the test that needs it?

@ghiggi
Copy link
Contributor Author

ghiggi commented Nov 17, 2022

Ready to be merged

@djhoese djhoese merged commit 80aeb8e into pytroll:main Nov 17, 2022
@ghiggi ghiggi deleted the feature-area-boundary-method branch November 18, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants