Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune tolerance to fix test failures with PROJ 9.1.1. #485

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

sebastic
Copy link
Contributor

@sebastic sebastic commented Dec 7, 2022

As reported in #484, test_area_def_geocentric_resolution fails with PROJ 9.1.1 because the tolerance is exceeded.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug report and the quick fix! Glad you figured out what was causing it.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #485 (0d97737) into main (790c847) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          74       74           
  Lines       12890    12890           
=======================================
  Hits        12159    12159           
  Misses        731      731           
Flag Coverage Δ
unittests 94.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/test/test_geometry.py 99.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.851% when pulling 0d97737 on sebastic:test_area_def_geocentric_resolution into 790c847 on pytroll:main.

@djhoese djhoese added the bug label Dec 7, 2022
@djhoese djhoese merged commit 35782d0 into pytroll:main Dec 7, 2022
@sebastic sebastic deleted the test_area_def_geocentric_resolution branch December 7, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build with Shapely 2.0
3 participants