Deprecate AreaDefinition 'rotation' argument #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
added
enhancement
backwards-incompatibility
Codecov Report
@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 93.94% 94.27% +0.32%
==========================================
Files 78 78
Lines 12920 12838 -82
==========================================
- Hits 12138 12103 -35
+ Misses 782 735 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
djhoese
force-pushed
the
deprecate-area-rotation
branch
from
f644200
to
904df93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with @loreclem on slack, we decided that it should be OK to deprecate the functionality added by him via the
rotationkeyword argument in the AreaDefinition. As far as I know this functionality was not used by anyone (even Lorenzo doesn't use it anymore) and should be replaced by parameters to the CRS (projection) being defined for the area. Overall, I wanted to remove this to cleanup code that was/is likely not being used by anyone and only makes the code harder to maintain.Note: This PR is based on #464 so it has a lot of commits and changes that will go away when that PR is merged.
git diff origin/main **/*py | flake8 --diff