Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of small typos found in documentation. #501

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

flamingbear
Copy link
Contributor

Just found a couple of typos reading the docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Curiously the note seems to get rendered just fine. I would have though this would fail too. I guess improved syntax is still good...I'm just confused.

https://pyresample.readthedocs.io/en/latest/swath.html#resample-bilinear

Don't worry about the pre-commit issues right now. We (pyresample maintainers) will need to make a separate PR to fix these. Then we'll merge those fixes into your PR and finally merge these fixes.

@flamingbear
Copy link
Contributor Author

You're not confused, it actually doesn't get rendered properly.
Screen Shot 2023-03-01 at 2 43 27 PM

@djhoese
Copy link
Member

djhoese commented Mar 1, 2023

Ah I was looking at the previous note. Well extra good that you made this PR then. Thanks. I'll try to get to the pre-commit failures tonight or tomorrow.

@djhoese
Copy link
Member

djhoese commented Mar 2, 2023

Ok I've merged the CI fixes into main and then merge that into your main branch. If (when!) you make future contributions to pyresample you'll want to make a new git branch before doing so. Once this is merged you'll have some odd behavior where your main is not in sync with upstream (pytroll/pyresample) main. For now, don't worry about it.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #501 (713ba9a) into main (1b2a130) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          78       78           
  Lines       12838    12838           
=======================================
  Hits        12103    12103           
  Misses        735      735           
Flag Coverage Δ
unittests 94.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage: 93.795%. Remained the same when pulling 713ba9a on flamingbear:main into 1b2a130 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Mar 2, 2023

Thanks!

@djhoese djhoese merged commit a94ab67 into pytroll:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants