Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more warnings encountered during tests #513

Merged
merged 4 commits into from
May 7, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 5, 2023

More PROJ and invalid value warnings that are raised during testing

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label May 5, 2023
@djhoese djhoese requested review from mraspaud and pnuu May 5, 2023 18:40
@djhoese djhoese self-assigned this May 5, 2023
@djhoese
Copy link
Member Author

djhoese commented May 5, 2023

This PR gets us from 677 warnings to 253 warnings. Quite the improvement. Here's the breakdown pytest tells me of the remaining ones:

pyresample/test/test_area_config.py: 4 warnings
pyresample/test/test_bilinear.py: 27 warnings
pyresample/test/test_bucket.py: 20 warnings
pyresample/test/test_data_reduce.py: 2 warnings
pyresample/test/test_ewa_ll2cr.py: 1 warning
pyresample/test/test_geometry_legacy.py: 10 warnings
pyresample/test/test_grid.py: 9 warnings
pyresample/test/test_image.py: 15 warnings
pyresample/test/test_utils.py: 27 warnings
pyresample/test/test_geometry/test_area.py: 2 warnings
pyresample/test/test_geometry/test_swath.py: 4 warnings

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #513 (ed0efa2) into main (327cec1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   94.31%   94.32%           
=======================================
  Files          79       79           
  Lines       12936    12944    +8     
=======================================
+ Hits        12201    12209    +8     
  Misses        735      735           
Flag Coverage Δ
unittests 94.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/geometry.py 87.50% <100.00%> (+<0.01%) ⬆️
pyresample/gradient/__init__.py 95.16% <100.00%> (ø)
pyresample/test/test_dask_ewa.py 98.94% <100.00%> (-0.01%) ⬇️
pyresample/test/test_geometry/test_swath.py 100.00% <100.00%> (ø)
pyresample/test/test_gradient.py 99.00% <100.00%> (+0.01%) ⬆️

@coveralls
Copy link

coveralls commented May 5, 2023

Coverage Status

Coverage: 93.846% (+0.004%) from 93.843% when pulling ed0efa2 on djhoese:remove-warnings2 into 327cec1 on pytroll:main.

@djhoese djhoese merged commit 4b75366 into pytroll:main May 7, 2023
@djhoese djhoese deleted the remove-warnings2 branch May 7, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants