Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproj TransformDirection enum for better performance #536

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 14, 2023

As mentioned by @snowman2 in #532, using the pyproj enum for these operations is slightly faster than not using it. This is a simple import and usage.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added bug performance improves speed or decreases memory consumption, but does not otherwise change functionality labels Aug 14, 2023
@djhoese djhoese self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #536 (93e8178) into main (046acf6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          82       82           
  Lines       13052    13055    +3     
=======================================
+ Hits        12303    12306    +3     
  Misses        749      749           
Flag Coverage Δ
unittests 94.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyresample/_spatial_mp.py 83.82% <100.00%> (+0.11%) ⬆️
pyresample/geometry.py 87.65% <100.00%> (+<0.01%) ⬆️
pyresample/slicer.py 90.76% <100.00%> (+0.07%) ⬆️

@coveralls
Copy link

Coverage Status

coverage: 93.838% (+0.002%) from 93.836% when pulling 93e8178 on djhoese:bugfix-proj-enums into 046acf6 on pytroll:main.

@djhoese djhoese merged commit e258c43 into pytroll:main Aug 14, 2023
24 checks passed
@djhoese djhoese deleted the bugfix-proj-enums branch August 14, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug performance improves speed or decreases memory consumption, but does not otherwise change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants