Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary proj4 argument parsing from get_area_def #548

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 11, 2023

Removes an unnecessary and likely unused PROJ.4 string -> dict conversion in get_area_def. See #547 for more info.

@djhoese djhoese requested a review from mraspaud October 11, 2023 21:08
@djhoese djhoese self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #548 (0c6289b) into main (ba09e7d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   94.25%   94.25%   -0.01%     
==========================================
  Files          82       82              
  Lines       13077    13076       -1     
==========================================
- Hits        12326    12325       -1     
  Misses        751      751              
Flag Coverage Δ
unittests 94.25% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyresample/area_config.py 90.55% <100.00%> (-0.03%) ⬇️

@coveralls
Copy link

Coverage Status

coverage: 93.832% (-0.001%) from 93.833% when pulling 0c6289b on djhoese:feat-proj4-args-get-area into ba09e7d on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mraspaud mraspaud merged commit c0025ed into pytroll:main Oct 12, 2023
25 of 27 checks passed
@djhoese djhoese deleted the feat-proj4-args-get-area branch October 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should this warning be addressed?
3 participants