Fix shortcut for prime meridian checks #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 94.25% 94.26%
=======================================
Files 82 82
Lines 13076 13076
=======================================
+ Hits 12325 12326 +1
+ Misses 751 750 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This was a pretty simple PR so just merging to get it off of my TODO list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shortcut exists in the code to avoid having to convert a CRS to a PROJ.4 dict if it isn't needed. I'm not sure how or why, but
.prime_meridianis not an integer, it is an object, and comparing it to== 0will always give False from what I'm seeing. I should have always been using.prime_meridian.longitude.I'm not exactly sure how to test this as it is just a performance thing (avoid unnecessary conversions). The end result should have always been the same.
git diff origin/main **/*py | flake8 --diff