-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attrs to future swath definition #578
Conversation
You brought up |
I don't know. On one hand, we should encourage users to go over to dask, but on the other hand, maybe that's a showstopper for some (I have not heard of such myself though)? |
I think it is more of the Side note: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 94.05% 94.01% -0.04%
==========================================
Files 90 92 +2
Lines 13575 13836 +261
==========================================
+ Hits 12768 13008 +240
- Misses 807 828 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyresample/future/geometry/swath.py
Outdated
Swath cartesian coordinates | ||
""" | ||
|
||
def __init__(self, lons, lats, crs=None, nprocs=1, attrs=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove nprocs
. The commit message says "for backwards compatibility". There is no backwards compatibility in the future modules...at least let's try really hard to avoid it. If it is going to be here then it at least needs a warning or something about it being deprecated. But I'd rather have a create_swath_def
pytest fixture that excludes nprocs
from the kwargs when creating the new version of the swath class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't understand the gist of your previous comments obviously. Removing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, ready for rereview :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going back and forth with me. Looks good. It's giving me a lot of ideas on where we could take this, but we'll have to get to that later.
This PR adds attrs to the future swath definition.
git diff origin/main **/*py | flake8 --diff