Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimize_projection handling in YAML parsing #585

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 16, 2024

Broken in #577. I accidentally stopped passing/parsing optimize_projection to DynamicAreaDefiniton objects parsed from YAML. This was first noticed in Satpy's tests. This PR fixes it. As stated in #577, I'd still like to follow this up with a PR to move metadata from YAML being any random kwarg to being an explicit attrs key.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label Feb 16, 2024
@djhoese djhoese self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c94b08) 93.99% compared to head (4dfcda6) 94.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   93.99%   94.00%           
=======================================
  Files          92       92           
  Lines       13777    13785    +8     
=======================================
+ Hits        12950    12958    +8     
  Misses        827      827           
Flag Coverage Δ
unittests 94.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 93.66% (+0.004%) from 93.656%
when pulling 4dfcda6 on djhoese:bugfix-opt-proj-yaml
into 56da958 on pytroll:main.

@djhoese djhoese merged commit 8549a9e into pytroll:main Feb 16, 2024
26 of 27 checks passed
@djhoese djhoese deleted the bugfix-opt-proj-yaml branch February 16, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants