Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding area repr map section HTML #615

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 27, 2024

These changes help control how AreaDefinitions and others are represented when plotted for sphinx documentation (specifically Satpy). See pytroll/satpy#2864 for more information. No TDD on this one.

CC @BENR0

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Fully documented

@djhoese djhoese requested a review from mraspaud August 27, 2024 16:00
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.97%. Comparing base (0a47fd3) to head (8002a7a).
Report is 6 commits behind head on main.

Files Patch % Lines
pyresample/_formatting_html.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   93.97%   93.97%   -0.01%     
==========================================
  Files          86       86              
  Lines       13819    13825       +6     
==========================================
+ Hits        12987    12992       +5     
- Misses        832      833       +1     
Flag Coverage Δ
unittests 93.97% <96.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese self-assigned this Aug 27, 2024
@coveralls
Copy link

Coverage Status

coverage: 93.676% (-0.004%) from 93.68%
when pulling 8002a7a on djhoese:feat-html-bokeh
into af0d4cc on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 90bdceb into pytroll:main Aug 28, 2024
24 of 26 checks passed
@djhoese djhoese deleted the feat-html-bokeh branch August 28, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants