Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cibuildwheel to fix setuptools 74.0.0 compatibility #616

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

mraspaud
Copy link
Member

This is to solve compilation problems on windows arm64.

Also attempts to port setup.cfg to pyproject.toml

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Fully documented

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (8002a7a) to head (8fe29a0).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          86       86           
  Lines       13825    13825           
=======================================
  Hits        12992    12992           
  Misses        833      833           
Flag Coverage Δ
unittests 93.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese changed the title Pin setuptools to avoid compilation problems Update cibuildwheel to fix setuptools 74.0.0 compatibility Aug 28, 2024
@djhoese
Copy link
Member

djhoese commented Aug 28, 2024

@mraspaud See pypa/setuptools#4610 for details but it seems cibuildwheel's newest release fixes an issue that setuptools 74.0.0 was running into. Updating cibuildwheel in my test debug-wheels branch seems to have success building, but then failed on Python 3.13 because pyproj hasn't released 3.13 wheels yet. I've skipped building for Python 3.13 until pyproj is able to make their compatible release.

@coveralls
Copy link

Coverage Status

coverage: 93.676%. remained the same
when pulling 8fe29a0 on mraspaud:fix-setuptools-version
into 280c225 on pytroll:main.

@djhoese djhoese merged commit 5c05460 into pytroll:main Aug 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants