-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add MIRS file reader #1285
Conversation
DeepCode's analysis on #b990f9 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 90.07% 89.79% -0.29%
==========================================
Files 218 219 +1
Lines 31580 31707 +127
==========================================
+ Hits 28447 28471 +24
- Misses 3133 3236 +103
Continue to review full report at Codecov.
|
@djhoese In this commit, the file metadata is taking precedence over metadata in the yaml for the metop file used for testing. (IMG_SX.M2.D17037.S1601.E1607.B0000001.WE.HR.ORB.nc). Therefore, standard_name is added when reading the file metadata. I thought this line in the available_datasets meant that it is possible to append new information to the metadata:
Can the boolean be True, False or None? Or is it only either True or None? I think the available_dataset() information above is saying, "Even if the availability "boolean" is True rather than None, a file handler could provide additional datasets." After that line, what is the more identifying DataID? Is this referring to the more definitive DataIDs like Brightness Temperature data defined by frequency and polarization "btemp_23v" versus the wider scope of BT? If so, then that is working correctly in this reader, because both the BT and the definitive brightness temperature channels are being yielded. Is there a way to keep variable metadata from a yaml and use metadata from a file, or is it either/or? |
Replaced by #1511 |
This adds a reader for files from MIRS.
flake8 satpy
AUTHORS.md
if not there already