-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GSICS calibration in SEVIRI HRIT reader. #1323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 220 220
Lines 32510 32512 +2
=======================================
+ Hits 29303 29305 +2
Misses 3207 3207
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I trust you validated with real data?
Yes, tested against 4 SEVIRI scenes. Plus, this PR uses the same method used in both the NAT reader and in the EUM ATBD - so we can be pretty confident it's now correct :) |
So if the same method is used in multiple places, we could refactor the code to use the same function, right? Not saying it should be done in this PR though... |
I think the readers are so different that it's not worth the effort, tbh. |
Ok, merging then. |
Oops, that was me not reading the documentation 🙈 Thanks for fixing this @simonrp84 ! |
The SEVIRI readers (NAT + HRIT) have the option to use the default (IMPF) or updated (GSICS) calibration coefficients for transforming digital number into radiance.
The HRIT reader, however, has a bug that means the calibration is invalid if
GSICS
mode is selected.This PR fixes the bug by multiplying the GSICS offset by the GSICS slope value, as is recommended in the user guide and as is already done in the NAT reader.
flake8 satpy