Refactor 'ahi_hsd' reader and make overview/overview_raw consistent with ABI #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
added
component:readers
component:compositors
cleanup
Codecov Report
@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
+ Coverage 93.39% 93.40% +0.01%
==========================================
Files 273 275 +2
Lines 40622 40728 +106
==========================================
+ Hits 37940 38044 +104
- Misses 2682 2684 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mini-PR on the path toward improving the performance of the ahi_hsd/abi_l1b true_color generation as discussed in #1902. This is mostly just cleanup with a small modification to the space masking code to pass the chunk size of the data that the mask will be used on. This is just to avoid future issues where fancy chunking may not match with the
PYTROLL_CHUNK_SIZE.I also updated the
overviewcomposite to add anoverview_rawso they match what the ABI composites do. I also made the composites based on channel name instead of wavelength.About pre-commit: bandit complained about the use of PIPE in the utils module, but I'm not sure there is an easy way around that. Mypy also complained about an import in
_compat.pybut I couldn't seem to make it happy (the import only exists in Python 3.8+ and it must be running in Python 3.7). I turned off hooks so I could do the last commit.