Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to be more flexible to CRS and enhancement changes #2002

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 31, 2022

This is an update needed for pytroll/pyresample#415 so that satpy tests still pass with those pyresample changes. One lesson learned is that +init=EPSG:XXXX does not respect the axis order of the EPSG definition. Using EPSG:XXXX does.

This PR also includes refactoring of the enhancements tests because they were causing failures when combined with my trollimage PR here: pytroll/trollimage#99

  • Tests added

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2002 (a8067a0) into main (3e94d59) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
- Coverage   93.54%   93.54%   -0.01%     
==========================================
  Files         279      279              
  Lines       41322    41317       -5     
==========================================
- Hits        38654    38649       -5     
  Misses       2668     2668              
Flag Coverage Δ
behaviourtests 4.78% <0.00%> (+<0.01%) ⬆️
unittests 94.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/enhancement_tests/test_enhancements.py 100.00% <100.00%> (ø)
satpy/tests/enhancement_tests/test_viirs.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_generic_image.py 98.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e94d59...a8067a0. Read the comment docs.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 94.004% when pulling a8067a0 on djhoese:refactor-crs-flexibility into 3e94d59 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit cafe001 into pytroll:main Feb 2, 2022
@djhoese djhoese deleted the refactor-crs-flexibility branch February 2, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants