-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.9 #2936
Drop python 3.9 #2936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
========================================
Coverage 96.08% 96.09%
========================================
Files 375 377 +2
Lines 54615 55075 +460
========================================
+ Hits 52478 52925 +447
- Misses 2137 2150 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hmm, looks like the 3.13 experimental was a bad idea... |
Pull Request Test Coverage Report for Build 11384578870Details
💛 - Coveralls |
Were all the FCI/decomp requirements/requests related to dropping Python 3.9 resolved? |
Yes I think so |
The last comment on #2741 confirms it. |
This PR drops support for python 3.9, as deemed reasonable in #2741. This superseeds #2741 which was difficult to merge with main.
Also, we added an experimental build for python 3.13.