-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dtype promotion in channel inversion #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 91.54% 91.57% +0.02%
==========================================
Files 11 11
Lines 4071 4081 +10
==========================================
+ Hits 3727 3737 +10
Misses 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions, probably because I have not really understood everything
Pushed two more commits to fix the issues in the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The
XRImage.invert()
promotes data tofloat64
when inversion parameters are given for each channel separately. Thedtype
was tested only for single inversion parameter case, not when they were given for each channel.This PR splits the test case into two and adds the
dtype
check also for the per-channel case. And fixes the issue.git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)