Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import netifaces only if used #134

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 2, 2022

This PR moves the netifaces import inside the trollmoves.utils.get_local_ips() function. This way pip install --no-dependencies trollmoves can be used with minimal additional packages when get_local_ips() isn't needed.

There were also some docstrings missing, which are added here.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu self-assigned this Nov 2, 2022
@pnuu pnuu requested a review from mraspaud as a code owner November 2, 2022 07:29
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #134 (1425427) into main (dd468fc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   87.45%   87.47%   +0.01%     
==========================================
  Files          18       18              
  Lines        3979     3983       +4     
==========================================
+ Hits         3480     3484       +4     
  Misses        499      499              
Flag Coverage Δ
unittests 87.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollmoves/utils.py 78.82% <100.00%> (+0.25%) ⬆️
trollmoves/server.py 66.14% <0.00%> (-0.11%) ⬇️
trollmoves/client.py 83.40% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pnuu pnuu added this to the v.0.11.0 milestone Nov 2, 2022
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 281599d into pytroll:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants