Fix iterate_messages() generator raising StopIteration #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
iterate_messages()
what was raisingStopIteration
when it should just return.Also adds an unit test for this function, and fixes a flake8 complaint about invalid usage of
assert
:trollmoves/tests/test_client.py:86:9: B011 Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().