Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword argument naming for publisher #76

Merged
merged 4 commits into from
Jun 5, 2020

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jun 5, 2020

This PR fixes a naming issue with a keyword argument passed to request_push().

Closes #77

@pnuu pnuu added the bug label Jun 5, 2020
@pnuu pnuu requested a review from mraspaud June 5, 2020 09:06
@pnuu pnuu self-assigned this Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #76 into master will increase coverage by 1.04%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   69.39%   70.44%   +1.04%     
==========================================
  Files          15       15              
  Lines        2905     2903       -2     
==========================================
+ Hits         2016     2045      +29     
+ Misses        889      858      -31     
Impacted Files Coverage Δ
trollmoves/move_it_base.py 0.00% <0.00%> (ø)
trollmoves/tests/test_client.py 98.18% <ø> (ø)
trollmoves/client.py 70.23% <87.50%> (+3.61%) ⬆️
trollmoves/utils.py 71.76% <0.00%> (+8.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f318e6d...651c1ef. Read the comment docs.

@pnuu pnuu mentioned this pull request Jun 5, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 7f7b2dc into pytroll:master Jun 5, 2020
@pnuu pnuu deleted the bugfix-publisher-kwarg-name branch June 11, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use correct publishers
2 participants