Extra dot in requirements file detected twice and not updated

[browniebroke]

I have an issue with PyUP on Cookiecutter Django project. This is a project template for Cookiecutter to quickly generate boilerplate for a Django project

We have 4 requirements file:

• One at the top of the project: requirements.txt
• 3 in the project template under {{cookiecutter.project_slug}}/requirements:
  • base.txt
  • local.txt
  • production.txt

We're receiving updates for all of them except base.txt, and I can't really understand why.

When looking at the PyUP dashboard, I can see the file is detected twice, with a dot in the name:

1. {{cookiecutter.project_slug}}/requirements/./base.txt
2. {{cookiecutter.project_slug}}/requirements/base.txt

Somehow, I assume this is preventing the update from arriving...?

I've tried to add them to the config file, or click "reload" in the dashboard, but the problem persists.

[lf1up]

@browniebroke thank you for this catch. This is an unusual bug causing strange behavior. I added it to the list of bugfixes.

[browniebroke]

Just adding here a new piece of info I've just discovered in case it helps. Pyup creates the branches to run the updates, but doesn't open a pull reques:

https://github.com/pydanny/cookiecutter-django/branches/all

[browniebroke]

I tracked it down to this recursive call to add_requirement_file:

pyup/pyup/bot.py

Line 519 in 6fb8638

self.add_requirement_file(other_file, sha=sha)

Which doesn't play nice with our production.txt and local.txt including the base requirements with a relative path: -r ./base.txt

https://github.com/pydanny/cookiecutter-django/blob/3dedd4dd4b55254a0fe6ef272c70c0a54c5e5188/%7B%7Bcookiecutter.project_slug%7D%7D/requirements/production.txt#L3

[browniebroke]

Changed the -r ./base.txt to -r base.txt fixed it, all good on my end now!

Do you want to keep this issue open to improve how you deal with this use case?