fix(cache): handle get_from_cache=None and ensure directory exists #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dylanpulver
commented
Jul 3, 2024
dylanpulver
commented
- Added file lock handling for get_from_cache=None
- Updated to filelock==3.12.2
- Ensured the cache directory exists
- Updated write_cache and corresponding tests
This was referenced Jul 3, 2024
Signed-off-by: Dylan Pulver <dylan@safetycli.com>
dylanpulver
force-pushed
the
fix/cache-handling
branch
from
01303d2 to
edbe6cd
Compare
dylanpulver
added a commit
that referenced
this pull request
Jul 9, 2024
author Dylan Pulver <dylanryanpulver@gmail.com> 1719603852 -0400 committer Dylan Pulver <dylanryanpulver@gmail.com> 1720552637 -0400 gpgsig -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQVa+zaLSZxm3/LxmooEm7VNVc3KwUCZo2MvQAKCRAoEm7VNVc3 Kw3EAP0acAlkZ3XYxvP5P8H4rAx4XXhAOp1Sv7OnQu/nbuPhIgEAitluAgNBdtDU jrt9pNq7Y1I76KOuKS+8VRewmuYJUQI= =bYzZ -----END PGP SIGNATURE----- fix(debug): fix --debug flag and associated tests - Fix --debug flag functionality - Add tests using runner.invoke - Fix and modify fetch_database function - Ensure all tests pass with appropriate patchings Fix --debug flag remove duplicate block undo linting remove test_debug file modify fetch_database fix(cache): handle get_from_cache=None and ensure directory exists (#544) Signed-off-by: Dylan Pulver <dylan@safetycli.com> chore: release 3.2.4 (#545) refactor: Jeff refactor suggestions Switch to use main() function refactor: adjust to cli() and cli_internal() refactor: fix click group to be on new cli() func fix: fix function order fix: fix function order fix: fix tests for debug flag changes remove uneeded files don't call dummy funcs fix(debug): fix --debug flag and associated tests - Fix --debug flag functionality - Add tests using runner.invoke - Fix and modify fetch_database function - Ensure all tests pass with appropriate patchings Fix --debug flag undo linting
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.