Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about the vscode editor #540

Merged
merged 25 commits into from
Apr 25, 2019
Merged

Added info about the vscode editor #540

merged 25 commits into from
Apr 25, 2019

Conversation

TomasRoj
Copy link
Contributor

Hey there,

I added some info about he vscode editor from microsoft. I added because many people are switching to vscode right now and beginners should have option to choose. I dont know if my text is correctly modified so I am open to any tip/requests for code change.

@encukou
Copy link
Member

encukou commented Apr 18, 2019

Hi,
If I read the privacy statement linked from the VS Code page correctly, the editor may send your files to Microsoft:

Text, inking, and typing data. Text, inking, and typing data and related information.

Content. Content of your files and communications you input, upload, receive, create, and control.

I'm very wary of recommending this as a default choice.

@benabraham
Copy link
Member

May doesn't mean does, but it does and you have to opt-out.

https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-telemetry-reporting

Does Atom have opt-in for this?

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

Important note here - this is used for beginners PyLadies courses. Changing the default cannot happen without consulting the coaches.

@TomasRoj
Copy link
Contributor Author

Ok, I changed things you said. As @benabraham said it can be diabled. @hroncok How I can contact them or consult it?

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

I'll lure them here.

@TomasRoj
Copy link
Contributor Author

Oh, okay thanks!

@golyalpha
Copy link

Personally, I'm alright with it, use it all the time, and it is faster than Atom in my experience (by which I mean timings, so, time to start up, etc.).
It also has a lot better support for Python from my experience, supports virtual environments and integrates with tools like Pipenv.
Even if we consider things like autocomplete and IntelliSense as downsides for teaching the language, VSCode doesn't offer that by default - requires an installation of the Python extension.

Considering privacy: VSCodium comes to the rescue here, with VSCode builds without the Microsoft stuff - not a recommendation, since I haven't actually tried out VSCodium myself. Then again, you can also just disable telemetry in VSCode.

@TomasRoj
Copy link
Contributor Author

@golyalpha So is everything ok? Can this PR be merged? I see some error in travis

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

It also has a lot better support for Python from my experience, supports virtual environments and integrates with tools like Pipenv.

I'd argue that for beginners we don't want those things. We need to explain how they actually work and they should not be inclined to "click a magic button" instead.

@TomasRoj
Copy link
Contributor Author

TomasRoj commented Apr 18, 2019

Yes, there was "run from terminal" text. But someone here said that terminal will be explained in next lessons. So instead of that there is this "magic button". But I think there is no reason explain anything in "python , file name". And it will be faster to test and deploy code.

@golyalpha
Copy link

@hroncok Read the next line.

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

I'd argue against any button that runs Python code. Note that it's not productivity that we are trying to achieve, but understanding.

@TomasRoj
Copy link
Contributor Author

@hroncok there are two options. Install the run code extension or run code via terminal.

@golyalpha
Copy link

@hroncok I'm not arguing that. I also mentioned, that VSCode doesn't offer that kind of functionality by default, so I don't think that this argument is even appropriate for this kind of discussion. Tell me if I'm wrong though.

@TomasRoj
Copy link
Contributor Author

I think that beginner will not understand theese things. VSCode is powerful code editor. And thats all. Beginners dont know theese things.

@golyalpha
Copy link

golyalpha commented Apr 18, 2019

Honestly, if we're about to get into a discussion about what VSCode with extensions is capable of, and how we don't want that, we should also remember that Atom has addons that half the time do much of the same things.

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

I don't know either of those editors. So I'll crawl back under my rock. Sorry about misdirecting this discussion.

@hroncok
Copy link
Member

hroncok commented Apr 18, 2019

Yet note that the text currently actually talks about some kind of extension installation.

@TomasRoj
Copy link
Contributor Author

@golyalpha yes, yes... I just added info about good text editor that beginners will have that option to choose what is best for them. And thats all. @hroncok no problem. Dont worry about that.

@TomasRoj
Copy link
Contributor Author

Ok I changed vscode to visual studio code and deleted the plugin tutorial. And fixed some typos

encukou added 6 commits April 23, 2019 17:48
Remove the "aby zlepšil uživatelské prostředí" (as of now,
the Privacy Policy lists 17 reasons data is collected!).

Include a note that the telemetry may send the content
of your files. Citing the current privacy policy:

> The data we collect can include the following:
> [...]
> **Text, inking, and typing data.** Text, inking, and typing
> data and related information.
> [...]
> **Content.** Content of your files and communications you
> input, upload, receive, create, and control.

That might cover anything you type in or open in the editor.
(Since the telemetry is closed-source, it's hard to tell if
they're actually sending this.)
This is written for people who don't know Atom, so that reference
needs to go.

Also, we don't need to tell them how easy the installation is.
They'll try, and if they find it easy, they'll know!
@encukou
Copy link
Member

encukou commented Apr 23, 2019

I'd be OK merging this with these changes: https://github.com/TomasRoj/naucse.python.cz/pull/1

  • Recommend just one editor – move Atom to Notepad++
  • Include telemetry opt-out instructions in Czech
  • Fix syntax, links, template sections

@TomasRoj
Copy link
Contributor Author

I don't fully understand what do you mean with move atom to notepad ++.

@TomasRoj
Copy link
Contributor Author

Ok merged that

@TomasRoj
Copy link
Contributor Author

So is everything ok from my side?

Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me. The change itself is IMHO a good idea because Atom is really slow even on the newer machines. Time will show us whether VS Code is a good replacement.

@hroncok hroncok dismissed their stale review April 24, 2019 12:49

changed

@TomasRoj
Copy link
Contributor Author

So can we merge?

@hroncok
Copy link
Member

hroncok commented Apr 24, 2019

Tomáš, please, stop doing this. I would consider it OK to send bumps after this is ignored for couple days, but repeatedly asking "can we merge this? can we merge this?" after every comment is very annoying and may be considered as rude. Please, show some patience. This has high changes for being merged as is, yet there is still one detailed open question about subpages ordering.

Ultimately, I leave it to @encukou to decide how and when to merge this.

@TomasRoj
Copy link
Contributor Author

Sorry

@encukou encukou merged commit 1363d39 into pyvec:master Apr 25, 2019
@encukou
Copy link
Member

encukou commented Apr 25, 2019

Merged! Thanks for initiating the change and all the discussions.

@TomasRoj
Copy link
Contributor Author

Thank you so much, I am glad that I can helped.

@TomasRoj TomasRoj deleted the patch-1 branch April 25, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants