adding usb_control_in functionality #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuDartiailh
requested changes
Oct 23, 2019
| length, | ||
| timeout=self.timeout) | ||
|
|
||
| #TODO satisfy the second half of the problem -i.e. sending buffer the optional data stage |
There was a problem hiding this comment.
You can try using to do a direct read. Using self.read means you are starting a full USBTMC request which is not what we want here. See https://github.com/pyvisa/pyvisa-py/blob/master/pyvisa-py/usb.py#L108
|
ping @Zanobos |
|
Hi @MatthieuDartiailh , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: pyvisa/pyvisa#466 the pyvisa-py backend is missing the implementation of usb_control_in. This patch applies the modification needed to have it working. Tested and working with a bk8600.
Disclaimer: Is implemented the feature of control_transfer, but not the one of optional data stage - I miss the specifications and the knowledge to do that part (I tried with a plain self.read(length), but it's not enough).
If anyone can lead me to the right way, I can provide implementation for that part too.