Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-pr-branch action to update PR branch #604

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

tkoyama010
Copy link
Member

Overview

The job of the action is to help click "Update branch" button for us. Designed to work with the auto-merge and "Require branches to be up to date before merging" options. It will update the newest open PR that match the below conditions

  • The PR has the auto-merge option enabled
  • The PR has 1 approvals and no changes-requested review
  • The PR branch has no conflicts with the base branch
  • The PR branch is behind the base branch

image

Details

@tkoyama010 tkoyama010 enabled auto-merge (squash) August 1, 2024 07:52
@tkoyama010
Copy link
Member Author

LGTM

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because tkoyama010 said so in here :shipit:

@tkoyama010 tkoyama010 added the maintenance Low-impact maintenance activity label Aug 1, 2024
@larsoner
Copy link
Contributor

larsoner commented Aug 1, 2024

I see how in principle this could help. But in practice if this had been in place when dependabot opened a ton of PRs, as soon as one was merged all of them would have been updated, creating quite a backlog/overkill in CI jobs. I almost think it's easier to manually update-and-merge one by one?

@tkoyama010
Copy link
Member Author

I see how in principle this could help. But in practice if this had been in place when dependabot opened a ton of PRs, as soon as one was merged all of them would have been updated, creating quite a backlog/overkill in CI jobs. I almost think it's easier to manually update-and-merge one by one?

Thank you for your comment! This is actually to select one of the PRs and update only that one. Does that address your concern?

@larsoner
Copy link
Contributor

larsoner commented Aug 5, 2024

Ahh okay I misunderstood -- let's try it then!

@larsoner larsoner merged commit 009d4b4 into main Aug 5, 2024
29 checks passed
@larsoner larsoner deleted the maint/update-pr-branch branch August 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants