You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lesson from #494 is that all Numba decorated functions must be tested with care, meaning not just via py_func() or physical examples, but "indirectly". I'm not sure how to do this systematically, but I hope this issue can guide us in that direction.
The issue refers to different results on Windows and Linux produced by a Numba decorated function for converting a Euler angle triplet to a quaternion. It was fixed by replacing array creation in two steps
For some reason, the two-step creation gave garbage results on Windows but not on Linux, while the latter gave same results on both OS. This was not caught in testing, but is now, by testing another function which calls this function.
The text was updated successfully, but these errors were encountered:
The lesson from #494 is that all Numba decorated functions must be tested with care, meaning not just via
py_func()
or physical examples, but "indirectly". I'm not sure how to do this systematically, but I hope this issue can guide us in that direction.The issue refers to different results on Windows and Linux produced by a Numba decorated function for converting a Euler angle triplet to a quaternion. It was fixed by replacing array creation in two steps
kikuchipy/kikuchipy/_rotation/__init__.py
Lines 65 to 69 in 5311982
with creation in one step
kikuchipy/kikuchipy/_rotation/__init__.py
Lines 65 to 68 in adfc6f0
For some reason, the two-step creation gave garbage results on Windows but not on Linux, while the latter gave same results on both OS. This was not caught in testing, but is now, by testing another function which calls this function.
The text was updated successfully, but these errors were encountered: