Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of two Numba functions #499

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Jan 11, 2022

Description of the change

  • Improve tests of private Numba functions. With these additions, Orientation refinement produces rubbish results on some Windows installations #494 and the 0.5.7 patch release could have been avoided.
  • Stress in the contributing guide that Numba functions must be tested both by calling their py_func() for coverage and their machine code by calling them directly! This would have caught the case where a Numba function gave different results on Windows and Ubuntu from the same Python (NumPy) code.
  • Move contributing guide and code of conduct to the top directory to increase visibility.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to .all-contributorsrc and the table is regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added documentation This relates to the documentation 📋 tests labels Jan 11, 2022
@hakonanes hakonanes added this to the v0.6.0 milestone Jan 11, 2022
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the maintenance This relates to package maintenance label Jan 11, 2022
@hakonanes hakonanes merged commit 1172a0b into pyxem:develop Jan 11, 2022
@hakonanes hakonanes deleted the improve-numba-testing branch January 11, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant