Solution refactor made #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pzmuda1
commented
Apr 11, 2021
•
pzmuda1
commented
- Updated libraries version - to get ridd off tech debt,
- Get ridd off enzyme in favor of react-testing-library - recommended library for testing, config had to be changed from enzyme after react upgrade so also changed,
- Moved to function components - most popular way with hooks usage,
- Added more tests
- Added basic columns config to make table more reusable - data table had defined way of rendering rows, that was changed to make it more reusable
- Get rid off enzyme in favor of react-testing-library - Moved to function components - Added more tests - Added basic columns config to make table more reusable - Added possibility to change current page from outside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.