Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all dependencies and create a new build for iOS #1

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Upgrade all dependencies and create a new build for iOS #1

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ce65c6b
prepare for cordova latest
madhums Apr 14, 2023
877132c
use es6 string literal and change LANDING_URL to checker.thequestionm…
madhums Apr 28, 2023
184633b
update config to include access and support for iPad
madhums Apr 28, 2023
e00c687
update cordova-ios@6.3.0
madhums Apr 28, 2023
f5447a7
fix regex output
madhums May 1, 2023
492999c
bump package and app store app version to 4.0.0
madhums May 1, 2023
c46795f
add app=Questionmark query param to landing url
madhums May 1, 2023
57eb046
update readme
madhums May 1, 2023
0b25075
update readme
madhums May 1, 2023
9d69d95
remove ios-deploy from dev deps as it gets added by cordova
madhums May 1, 2023
e8a11f2
update readme
madhums May 1, 2023
f98e298
remove access origin as this is default
madhums May 1, 2023
97cce7b
update readme
madhums May 1, 2023
f8a8489
remove cordova-ios and package-lock.json
madhums May 1, 2023
06ab98e
update code comments
madhums May 1, 2023
bacc54e
allow custom url scheme for ios
madhums May 2, 2023
bbc9597
ignore package-lock.json
madhums May 2, 2023
ff4e293
update readme instructions
madhums May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Features:
npm i
madhums marked this conversation as resolved.
Show resolved Hide resolved
npx cordova platform add ios
madhums marked this conversation as resolved.
Show resolved Hide resolved
npx cordova platform add android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest

npm install
npx cordova platform add ios      # when building iOS app on Mac OS
npx cordova platform add android  # when building Android app
npx cordova requirements          # check build requirements
npx cordova build ios             # when building iOS app on Mac OS
npx cordova build android         # when building Android app

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, feel free to do so!

npx cordova build ios
npx cordova build ios # if you are on a iOS supported platform
npx cordova build android
```
madhums marked this conversation as resolved.
Show resolved Hide resolved

Expand Down