feat: Do not build string switch with falsy values #102

q2s2t · Jul 11, 2021 · b7f799c · b7f799c
1 parent 48a74d6
commit b7f799c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/flags.js b/src/flags.js
@@ -66,7 +66,11 @@ const handle = flag => {
       return `-${flag.cli}${suffix}`
     },
     string: flag => {
-      return `-${flag.cli}${flag.value}`
+      if (flag.value) {
+        return `-${flag.cli}${flag.value}`
+      } else {
+        return ''
+      }
     },
     stringArray: flag => {
       const values = flag.value

diff --git a/test/unit/flags.spec.js b/test/unit/flags.spec.js
@@ -130,5 +130,13 @@ describe('Unit: flags.js', function () {
       rawFake.map(arg => expect(r).to.include(arg))
       expect(r).to.include('-bsp1')
     })
+
+    it('should not add string values if only key is pecidied', function () {
+      const r = fromOptions({
+        password: false,
+      })
+      expect(r).not.to.includes('-p')
+    })
+
   })
 })