eth/abi: allow parsing numerics from string inputs (#112)

* eth/abi: allow parsing numerics from string inputs * sepc: run rufo
q9f · Jun 10, 2022 · bb640c7 · bb640c7
1 parent c0bbae9
commit bb640c7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/eth/abi.rb b/lib/eth/abi.rb
@@ -306,6 +306,7 @@ def signature(interface)
 
     # Properly encodes unsigned integers.
     def encode_uint(arg, type)
+      arg = arg.to_i if arg.is_a? String
       raise ValueOutOfBounds, "Number out of range: #{arg}" if arg > Constant::UINT_MAX or arg < Constant::UINT_MIN
       real_size = type.sub_type.to_i
       i = arg.to_i
@@ -315,6 +316,7 @@ def encode_uint(arg, type)
 
     # Properly encodes signed integers.
     def encode_int(arg, type)
+      arg = arg.to_i if arg.is_a? String
       raise ValueOutOfBounds, "Number out of range: #{arg}" if arg > Constant::INT_MAX or arg < Constant::INT_MIN
       real_size = type.sub_type.to_i
       i = arg.to_i

diff --git a/spec/eth/abi_spec.rb b/spec/eth/abi_spec.rb
@@ -61,6 +61,13 @@
       end
     end
 
+    it "can encode numbers from string inputs" do
+      expect(Abi.encode(["uint256"], ["10000000000000000000000"])).to eq Abi.encode(["uint256"], [10000000000000000000000])
+      expect(Abi.decode(["uint256"], "00000000000000000000000000000000000000000000021e19e0c9bab2400000")).to eq [10000000000000000000000]
+      expect(Abi.encode(["int256"], ["20000000000000000000000"])).to eq Abi.encode(["int256"], [20000000000000000000000])
+      expect(Abi.decode(["int256"], "00000000000000000000000000000000000000000000043c33c1937564800000")).to eq [20000000000000000000000]
+    end
+
     it "can do encode and decode complex types" do
       types = [
         "bool",