Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing in constructor params to deploy #106

Merged
merged 4 commits into from
May 29, 2022
Merged

Enable passing in constructor params to deploy #106

merged 4 commits into from
May 29, 2022

Conversation

beacoding
Copy link
Contributor

@beacoding beacoding commented May 22, 2022

as per title

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #106 (6027a2b) into main (854a7bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          67       67           
  Lines        3801     3846   +45     
=======================================
+ Hits         3791     3836   +45     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <100.00%> (ø)
lib/eth/contract.rb 100.00% <100.00%> (ø)
spec/eth/client_spec.rb 100.00% <100.00%> (ø)
spec/eth/solidity_spec.rb 100.00% <100.00%> (ø)
lib/eth/abi.rb 100.00% <0.00%> (ø)
spec/eth/abi_spec.rb 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@beacoding beacoding changed the title Bea add constructor Enable passing in constructor params to deploy May 29, 2022
@beacoding beacoding closed this May 29, 2022
@beacoding beacoding reopened this May 29, 2022
@beacoding beacoding marked this pull request as ready for review May 29, 2022 01:54
@kurotaky kurotaky merged commit bb67fea into q9f:main May 29, 2022
@kurotaky
Copy link
Collaborator

@beacoding Thanks!

@q9f q9f added the enhancement New feature or request label May 30, 2022
mculp pushed a commit to mculp/eth.rb that referenced this pull request Aug 1, 2022
* Add missing def_delegator for constructor_inputs

* Enable passing in constructor to deploy contracts

* Call greeter function with params

* Update greeter.sol

Co-authored-by: Bea <bea@Beas-MacBook-Pro-2.local>
Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants