Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/client: add test for tx_succeeded? #183

Merged
merged 2 commits into from
Dec 21, 2022
Merged

eth/client: add test for tx_succeeded? #183

merged 2 commits into from
Dec 21, 2022

Conversation

q9f
Copy link
Owner

@q9f q9f commented Dec 21, 2022

after #173

@q9f q9f added the spec-tests label Dec 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #183 (55de840) into main (1633ed0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   99.70%   99.75%   +0.04%     
==========================================
  Files          70       70              
  Lines        4077     4086       +9     
==========================================
+ Hits         4065     4076      +11     
+ Misses         12       10       -2     
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <100.00%> (+1.25%) ⬆️
spec/eth/client_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit 1399e47 into main Dec 21, 2022
@q9f q9f deleted the q9f/client/success branch December 21, 2022 16:21
@kurotaky
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants